Migrate ContractCheckList Card to shadcn + StepsCard UI adjustment #5039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MananTank and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5039 +/- ##
=======================================
Coverage 45.30% 45.30%
=======================================
Files 1059 1059
Lines 54707 54707
Branches 3954 3954
=======================================
Hits 24786 24786
Misses 29230 29230
Partials 691 691
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
jnsdls
approved these changes
Oct 15, 2024
Contributor
Merge activity
|
…5039) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on improving the styling and structure of the `StepsCard` component in the dashboard by modifying the layout and updating the child elements to use `<p>` tags instead of `<Text>`, along with adjusting some class names for better styling consistency. ### Detailed summary - Increased the gap in the `flex` container from `gap-5` to `gap-7`. - Changed the margin-bottom of a `div` from `mb-3` to `mb-1`. - Replaced `<Text>` components with `<p>` elements for children content in multiple steps. - Updated `Link` components with new class names for consistent styling. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
jnsdls
force-pushed
the
10-16-move_contract_overview_page_components_to_app_router_folder_-_no_code_changes
branch
from
22abbaf to
52d89ce
Compare
jnsdls
force-pushed
the
10-16-migrate_contractchecklist_card_to_shadcn_stepscard_ui_adjustment
branch
from
a51607e to
0cf478e
Compare
Base automatically changed from
10-16-move_contract_overview_page_components_to_app_router_folder_-_no_code_changes
to
main
October 15, 2024 21:07
graphite-app
bot
deleted the
10-16-migrate_contractchecklist_card_to_shadcn_stepscard_ui_adjustment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on improving the styling and structure of the
StepsCardcomponent in the dashboard, particularly updating the spacing and replacingTextcomponents withptags for better semantic HTML.Detailed summary
divfromgap-5togap-7.divfrommb-3tomb-1.Textcomponents withptags for children content in multiple steps.Linkcomponents to include additional classes for styling.